Skip to content

[UR][L0] Return the build log on compilation failure #14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sarnex merged 1 commit into from
Aug 9, 2024
Merged

[UR][L0] Return the build log on compilation failure #14934

sarnex merged 1 commit into from
Aug 9, 2024

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Aug 2, 2024 •
edited
Loading

@sarnex sarnex mentioned this pull request Aug 2, 2024
Merged
@sarnex sarnex temporarily deployed to WindowsCILock August 2, 2024 15:43 — with GitHub Actions Inactive
@sarnex sarnex changed the title [UR] Return the build log on compilation failure [UR][L0] Return the build log on compilation failure Aug 2, 2024
@sarnex sarnex temporarily deployed to WindowsCILock August 2, 2024 17:02 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock August 5, 2024 15:09 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock August 5, 2024 16:08 — with GitHub Actions Inactive
@sarnex
Copy link
Contributor Author

sarnex commented Aug 5, 2024 •
edited
Loading

My reading of the UR contribution guide is that I should mark this as a ready for review now (UR PR is approved but not merged) and that I should still use my custom branch in the CMake file for now. Once the UR PR is merged I will update the CMake file here and then merge this PR. If I misunderstood let me know.

@sarnex sarnex marked this pull request as ready for review August 5, 2024 20:32
@sarnex sarnex requested a review from a team as a code owner August 5, 2024 20:32
@sarnex
Copy link
Contributor Author

sarnex commented Aug 7, 2024

@intel/unified-runtime-reviewers Ping on this one, thanks!

@omarahmed1111
Copy link
Contributor

omarahmed1111 commented Aug 9, 2024

@intel/unified-runtime-reviewers Ping on this one, thanks!

Will merge that next in the merge queue, will first merge UR part, then once we update CMake in this PR, will approve that so we could merge it.

@sarnex
Copy link
Contributor Author

sarnex commented Aug 9, 2024

@omarahmed1111 Thanks, I updated the CMake file to point at the UR commit. Am I good to merge this? There are no other commits in UR in between the last version bump and my UR commit. Thanks

@omarahmed1111
Copy link
Contributor

omarahmed1111 commented Aug 9, 2024 •
edited
Loading

@omarahmed1111 Thanks, I updated the CMake file to point at the UR commit. Am I good to merge this? There are no other commits in UR in between the last version bump and my UR commit. Thanks

Thanks! Yeah, this is good to go.

@sarnex sarnex merged commit c3a75b8 into intel:sycl Aug 9, 2024
@sarnex sarnex temporarily deployed to WindowsCILock August 9, 2024 14:48 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock August 9, 2024 15:33 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@omarahmed1111 omarahmed1111 omarahmed1111 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sarnex @omarahmed1111